Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ⚗️ add check-spelling.yml gh action #947

Merged
merged 17 commits into from
Sep 1, 2023
Merged

feat: ⚗️ add check-spelling.yml gh action #947

merged 17 commits into from
Sep 1, 2023

Conversation

peelar
Copy link
Member

@peelar peelar commented Aug 31, 2023 •
edited
Loading

Featuring:

  • cspell GitHub action
  • check-spelling global command that runs on all files
  • cspell command in lint-staged that checks if there are typos before committing
  • dictionary of commonly used proper names

@peelar peelar requested a review from a team August 31, 2023 07:50
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9853654

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-cms-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:39am
saleor-app-taxes ✅ Ready (Inspect) Visit Preview Sep 1, 2023 9:39am

lkostrowski
lkostrowski requested changes Aug 31, 2023
View reviewed changes
cspell.json Outdated
"VERCEL",
"Windi",
"windicss",
"xstate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these actual wordings? I dont see where we have xstate

Copy link
Member Author

@peelar peelar Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to only contain Saleor-specific names and integrations, as it will not scan package.json anymore

@lkostrowski
Copy link
Member

@peelar please add to Appstore repo too

@peelar
Copy link
Member Author

peelar commented Sep 1, 2023

@peelar please add to Appstore repo too

@lkostrowski done

krzysztofwolski
krzysztofwolski requested changes Sep 1, 2023
View reviewed changes
package.json Outdated
@@ -4,6 +4,7 @@
"scripts": {
"build": "turbo run build",
"check-deps": "syncpack list-mismatches",
"check-spelling": "cspell **/*.{jsx,tsx,js,ts}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing md files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@peelar peelar merged commit 0aa1d12 into main Sep 1, 2023
6 checks passed
@peelar peelar deleted the check-spelling branch September 1, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkostrowski lkostrowski lkostrowski approved these changes

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

Assignees

@peelar peelar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peelar @lkostrowski @krzysztofwolski