-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ORDER_FULLY_REFUNDED
#927
Conversation
🦋 Changeset detectedLatest commit: 11d530e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
11 Ignored Deployments
|
plase coop with @korycins and write the RFC that will cover missing APIs for refunds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have split Avatax and Taxjar into separate apps, the Taxes app is now deprecated. Please add the changes to apps/avatax
export function resolveAvataxTransactionLineNumber(line: OrderLineFragment) { | ||
return line.id.slice(-50); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Why not use Order.token
instead of shortening the ID?
Here's the comparison in length between token (UUID from Saleor database) and ID (base64 of Order:)
❯ echo "951feaa9-d613-4e0c-bd6a-373134ec3dc1" | wc -c
37
❯ echo "T3JkZXI6OTUxZmVhYTktZDYxMy00ZTBjLWJkNmEtMzczMTM0ZWMzZGMx" | wc -c
57
In the schema it's marked as deprecated, but since we still keep on finding use-cases for shorter IDs we might leave it (conversation: https://saleorcommerce.slack.com/archives/C0352SN0W3U/p1706698862183379)
Refactor AvataxDocumentCodeResolver to use a function instead of a class Refactor avatax-customer-code-resolver.ts to be functions instead of class Refactor AvataxCalculationDateResolver to use functions instead of class Refactor AvataxOrderConfirmedPayloadLinesTransformer to use functions instead of class Refactor AvataxCalculateTaxesPayloadLinesTransformer to a function Refactor classes to functions; group resolvers
Featuring:
ORDER_FULLY_REFUNDED
webhook that refunds the entire AvaTax transaction.Rel: #1166
Note:
Currently, no partial refunds are supported.