-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avatax metadata tax calculation date #843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c5ab76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
peelar
force-pushed
the
taxes/calculation-date
branch
from
August 3, 2023 08:52
25468fa
to
5c5ab76
Compare
lkostrowski
approved these changes
Aug 3, 2023
peelar
added a commit
that referenced
this pull request
Aug 4, 2023
* feat: ✨ add metadata tax calculation date * build: 👷 add changeset
peelar
added a commit
that referenced
this pull request
Aug 9, 2023
* feat: ✨ add metadata tax calculation date * build: 👷 add changeset
peelar
added a commit
that referenced
this pull request
Aug 10, 2023
* refactor: ♻️ extract order-metadata-manager * feat: 🚧 add basic boilerplate * feat: ✨ add readExternalIdFromOrderMetadata * Revert "feat: ✨ add readExternalIdFromOrderMetadata" This reverts commit a78d9d4. * feat: ✨ add order-cancelled avatax adapter * test: ✅ add tests for AvataxOrderCancelledPayloadTransformer * refactor: avataxId instead of externalId * refactor: ♻️ split up webhook response * build: ⬆️ upgrade avatax * refactor: ♻️ extend logging in webhook response errors * fix: 🐛 split privateMetadata and publicMetadata * fix: 🐛 use "DEFAULT" value of companyCode for commit to work * fix: ⚗️ fix voidTransaction type * refactor: 🚚 order_created -> order_confirmed * fix: 🐛 change voidReason * build: 👷 add changeset * refactor: 🔥 order_fulfilled webhook * feat: Avatax metadata tax calculation date (#843) * feat: ✨ add metadata tax calculation date * build: 👷 add changeset * feat: Avatax metadata document code (#844) * feat: ✨ provide document code through metadata field * build: 👷 add changeset * refactor: ♻️ fallback to default company code for migration * refactor: ♻️ patch order-created files and add deprecation note * Revert "refactor: 🔥 order_fulfilled webhook" This reverts commit fd09864. * refactor: ♻️ patch order-fulfilled files and add deprecation note * fix: 🐛 bring back deprecated webhooks to manifest * feat: ⚗️ add AppWebhookMigrator (#850) * refactor: 🚚 order_created -> order_confirmed * refactor: 🔥 order_fulfilled webhook * feat: ⚗️ add AppWebhookMigrator * feat: ✨ add mode to migrator * feat: ✨ add draft of run-report and migrateWebhook method * refactor: ♻️ address feedback * feat: ✨ add tests and new structure * refactor: 🔥 util * feat: ✨ add enable/disable webhook rollback flow * refactor: ♻️ modify the taxes-migration flow * refactor: ♻️ generalize document code & date resolver * chore: 🗃️ add run-migration * chore: 💡 update comments about migration flow * fix: 🐛 slice document code * refactor: ♻️ try/catch at the top level * chore: 💡 add comments * Update shiny-meals-wait.md * Update soft-steaks-know.md * Update soft-steaks-know.md * fix: ✅ fix test * feat: ✨ change createTransaction to createOrAdjustTransaction this feature grants idempotency of the transaction flow * feat: ✨ add number field to OrderConfirmed payload * chore: 💡 add deprecation comment to metadata method * docs: 📝 add todo comment to refactor sumPayloadLines * feat: ✨ add resolveStringOrThrow and use it for email * fix: 🐛 add missing number to mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
avataxTaxCalculationDate
. The value has to be valid UTC datetime string (e.g. "2021-08-31T13:00:00.000Z").Checklist
.github/dependabot.yaml
is up-to date.