Product Feed: Add attribute mapping #838

krzysztofwolski · 2023-08-02T10:42:45Z

Scope of the PR

Google feed has specialized fields for the attributes (Size, Color, etc). This change adds configuration for choosing the right attributes:

Which is later used for the feed generation:

<item>
<g:id>118223581</g:id>
<title>Paul's Balance 420 - 39</title>
<g:condition>new</g:condition>
<g:availability>in_stock</g:availability>
<g:product_type>Sneakers</g:product_type>
<g:description>Step into summer with the right balance.&nbsp;Every time your head goes down, you see these beauties, and your mood bounces right back up.</g:description>
<link>http://example.com</link>
<g:image_link>https://kot.eu.saleor.cloud/media/thumbnails/products/saleor-pauls-blanace-420-1_thumbnail_256.png</g:image_link>
<g:price>50.00 USD</g:price>
<g:size>39</g:size>  // mapped from product attributes
</item>
<item>
<g:id>124223581</g:id>
<title>Own your stack and data - iTunes</title>
<g:condition>new</g:condition>
<g:availability>in_stock</g:availability>
<g:product_type>Audiobooks</g:product_type>
<g:description>Own your investment, ditch vendor lock-in</g:description>
<link>http://example.com</link>
<g:image_link>https://kot.eu.saleor.cloud/media/thumbnails/products/saleor-own-your-stack-and-data-book_thumbnail_256.png</g:image_link>
<g:price>1.20 USD</g:price>
<g:material>iTunes</g:material>  // mapped from product attributes
<g:brand>Saleor Publishing</g:brand>  // mapped from product attributes
</item>

I've ditched the idea of keeping mapping in the metadata due to:

it would require additional permission for the app (manage Attributes)
some attributes like size, might be required in particular order defined by user (eg height/width). Keeping id mapping in the App metadata gives us this feature (keeping order distributed across the attributes would be more complicated)

Related issues

Related: #814

Checklist

.github/dependabot.yaml is up-to date.
I added changesets and read good practices.

changeset-bot · 2023-08-02T10:42:48Z

🦋 Changeset detected

Latest commit: 064b649

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
saleor-app-products-feed	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-08-02T10:42:49Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saleor-app-products-feed	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2023 4:21pm

9 Ignored Deployments

Name	Status	Preview	Updated (UTC)
saleor-app-cms-v2	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-crm	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-data-importer	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-emails-and-messages	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-invoices	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-klaviyo	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-search	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-slack	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm
saleor-app-taxes	⬜️ Ignored (Inspect)	Visit Preview	Aug 2, 2023 4:21pm

lkostrowski · 2023-08-02T11:59:33Z

.changeset/nine-dryers-wink.md

+"saleor-app-products-feed": minor
+---
+
+Added new feature: Attributes required by the Google Merchant can now be mapped to product attributes.


I think we can have a better message. No need to write "new feature" - this is followed by "minor"

Instead, please describe which exactly attributes are added.

lkostrowski · 2023-08-02T14:30:31Z

apps/products-feed/src/modules/app-configuration/app-configuration.router.ts

+    .query(async ({ ctx: { logger, apiClient } }) => {
+      const fetcher = new AttributeFetcher(apiClient);
+
+      const result = await fetcher.fetchAllAttributes().catch((e) => {


log error here and it should go to sentry

lkostrowski · 2023-08-02T14:40:15Z

apps/products-feed/src/modules/app-configuration/attribute-fetcher.ts

+  FetchAttributesWithMappingDocument,
+} from "../../../generated/graphql";
+
+export class AttributeFetcher {


nice implementation, maybe we can make it generic and put to shared

@lkostrowski well, thats copy of your implementation of the Caregory fetcher 😃

krzysztofwolski · 2023-08-02T16:22:11Z

@lkostrowski applied CRs. Spotted one missing attribute and added it.

* Add attribute mapping * Improve release note * Log the error * Add pattern attribute

krzysztofwolski self-assigned this Aug 2, 2023

github-actions bot added the App: Product Feed label Aug 2, 2023

vercel bot deployed to Preview – saleor-app-crm August 2, 2023 10:44 View deployment

vercel bot deployed to Preview – saleor-app-products-feed August 2, 2023 10:44 View deployment

vercel bot deployed to Preview – saleor-app-cms-v2 August 2, 2023 10:46 View deployment

vercel bot deployed to Preview – saleor-app-search August 2, 2023 10:46 View deployment

vercel bot deployed to Preview – saleor-app-klaviyo August 2, 2023 10:48 View deployment

vercel bot deployed to Preview – saleor-app-data-importer August 2, 2023 10:48 View deployment

vercel bot deployed to Preview – saleor-app-slack August 2, 2023 10:50 View deployment

vercel bot deployed to Preview – saleor-app-emails-and-messages August 2, 2023 10:50 View deployment

vercel bot deployed to Preview – saleor-app-taxes August 2, 2023 10:52 View deployment

vercel bot deployed to Preview – saleor-app-invoices August 2, 2023 10:52 View deployment

Add attribute mapping

01e165d

krzysztofwolski force-pushed the pf-attribute-matching branch from d868f2d to 01e165d Compare August 2, 2023 10:55

vercel bot deployed to Preview – saleor-app-search August 2, 2023 10:56 View deployment

vercel bot deployed to Preview – saleor-app-klaviyo August 2, 2023 10:57 View deployment

vercel bot deployed to Preview – saleor-app-products-feed August 2, 2023 10:58 View deployment

vercel bot deployed to Preview – saleor-app-cms-v2 August 2, 2023 11:00 View deployment

vercel bot deployed to Preview – saleor-app-taxes August 2, 2023 11:02 View deployment

vercel bot deployed to Preview – saleor-app-slack August 2, 2023 11:02 View deployment

vercel bot deployed to Preview – saleor-app-emails-and-messages August 2, 2023 11:04 View deployment

vercel bot deployed to Preview – saleor-app-data-importer August 2, 2023 11:04 View deployment

vercel bot deployed to Preview – saleor-app-invoices August 2, 2023 11:06 View deployment

vercel bot deployed to Preview – saleor-app-crm August 2, 2023 11:06 View deployment

krzysztofwolski marked this pull request as ready for review August 2, 2023 11:53

krzysztofwolski requested a review from a team August 2, 2023 11:53

lkostrowski requested changes Aug 2, 2023

View reviewed changes

Improve release note

41e85fb

krzysztofwolski added 2 commits August 2, 2023 18:18

Log the error

bd23bc4

Add pattern attribute

064b649

krzysztofwolski requested a review from lkostrowski August 2, 2023 16:20

vercel bot deployed to Preview – saleor-app-products-feed August 2, 2023 16:21 View deployment

lkostrowski approved these changes Aug 3, 2023

View reviewed changes

krzysztofwolski merged commit aece073 into main Aug 3, 2023
5 checks passed

krzysztofwolski deleted the pf-attribute-matching branch August 3, 2023 08:27

Tha-Toe pushed a commit to Flo3Digital/saleor-apps that referenced this pull request Aug 10, 2023

Product Feed: Add attribute mapping (saleor#838)

c6a76c7

* Add attribute mapping * Improve release note * Log the error * Add pattern attribute

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Product Feed: Add attribute mapping #838

Product Feed: Add attribute mapping #838

krzysztofwolski commented Aug 2, 2023 •

edited

Loading

changeset-bot bot commented Aug 2, 2023 •

edited

Loading

vercel bot commented Aug 2, 2023 •

edited

Loading

lkostrowski Aug 2, 2023

lkostrowski Aug 2, 2023

lkostrowski Aug 2, 2023

krzysztofwolski Aug 2, 2023

krzysztofwolski Aug 2, 2023

lkostrowski Aug 3, 2023

krzysztofwolski commented Aug 2, 2023

Product Feed: Add attribute mapping #838

Product Feed: Add attribute mapping #838

Conversation

krzysztofwolski commented Aug 2, 2023 • edited Loading

Scope of the PR

Related issues

Checklist

changeset-bot bot commented Aug 2, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Aug 2, 2023 • edited Loading

lkostrowski Aug 2, 2023

Choose a reason for hiding this comment

lkostrowski Aug 2, 2023

Choose a reason for hiding this comment

lkostrowski Aug 2, 2023

Choose a reason for hiding this comment

krzysztofwolski Aug 2, 2023

Choose a reason for hiding this comment

krzysztofwolski Aug 2, 2023

Choose a reason for hiding this comment

lkostrowski Aug 3, 2023

Choose a reason for hiding this comment

krzysztofwolski commented Aug 2, 2023

krzysztofwolski commented Aug 2, 2023 •

edited

Loading

changeset-bot bot commented Aug 2, 2023 •

edited

Loading

vercel bot commented Aug 2, 2023 •

edited

Loading