Added support for itemCode when handling order/checkout calc taxes in AvaTax
#1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d439e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
witoszekdev
previously approved these changes
Nov 12, 2024
| } | ||
| if (line.__typename === "OrderLine") { | ||
| return line.orderProductVariant?.sku ?? line.orderProductVariant?.id ?? ""; | ||
| } |
There was a problem hiding this comment.
suggestion: let's add invariant if there's some other __typename:
Suggested change
| } | |
| } | |
| throw new Error("Invariant: unknown line type") |
vercel
bot
temporarily deployed
to
Preview – saleor-app-products-feed
witoszekdev
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AvaTax
itemCodesupport when handling order or checkout calculate taxes webhooks. After this change app will senditemCodeto Avalara based on Saleor variant SKU or variant id.Order confirmed handling is not affected as it was already sending
itemCode.Scope of the PR
Related issues
Checklist