feat: improve sentry setup in Taxes App #1051
Conversation
🦋 Changeset detectedLatest commit: e909a4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
peelar
force-pushed
the
taxes/improve-sentry-setup
branch
from
0c84bb3
to
efc0c19
Compare
to be removed before merge
apps/taxes/turbo.json
Outdated
| "VERCEL_GIT_COMMIT_SHA", | ||
| "VERCEL_URL", | ||
| "VERCEL" |
There was a problem hiding this comment.
Won't this break caching? VERCEL_GIT_COMMIT_SHA will change on every single commit 🤔
There was a problem hiding this comment.
All env vars need to be referenced in turbo.json. Otherwise, we get an eslint error turbo/no-undeclared-env-vars.
There was a problem hiding this comment.
Could you use this? https://turbo.build/repo/docs/core-concepts/caching/environment-variable-inputs#unhashed-environment-variables
globalPassThroughEnv / passThroughEnv
This way it won't be included in cache
There was a problem hiding this comment.
Good catch. I added it there, but I had to change the eslint config. Unfortunately it doesn't take the globalPassThroughEnv vars into account
make the eslint rule warn in taxes
Features:
@next/envNext steps:
release-utilsto shared