Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache update on product webhooks #1036

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

krzysztofwolski
Copy link
Member

Scope of the PR

Due to longer lambda execution, we can skip independent cache update on webhooks.

Related issues

Checklist

@krzysztofwolski krzysztofwolski self-assigned this Sep 22, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 85f4830

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-app-products-feed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saleor-app-cms-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-crm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-data-importer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-emails-and-messages ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-invoices ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-klaviyo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-products-feed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-segment ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-slack ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 11:33am
saleor-app-taxes ✅ Ready (Inspect) Visit Preview Sep 22, 2023 11:33am

Copy link
Member

@lkostrowski lkostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove webhooks migration

@krzysztofwolski
Copy link
Member Author

Tested with >5k products, works without the issues 👍

@krzysztofwolski krzysztofwolski changed the base branch from feed-execution to main September 27, 2023 10:46
@krzysztofwolski krzysztofwolski requested a review from a team as a code owner September 27, 2023 10:46
@krzysztofwolski krzysztofwolski merged commit ae6dbb1 into main Sep 27, 2023
8 checks passed
@krzysztofwolski krzysztofwolski deleted the pf-remove-webhooks branch September 27, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants