Add support for authenticated proxies

.travis.s3cfg

@@ -47,7 +47,7 @@ multipart_chunk_size_mb = 15
 multipart_max_chunks = 10000
 preserve_attrs = True
 progress_meter = True
-proxy_host = 
+proxy_host =
 proxy_port = 0
 put_continue = False
 recursive = False

S3/ConnMan.py

@@ -15,6 +15,7 @@
     from .Custom_httplib27 import httplib
 import ssl
 
+from base64 import b64encode
 from logging import debug
 from threading import Semaphore
 from time import time
@@ -26,7 +27,7 @@
 
 from .Config import Config
 from .Exceptions import ParameterError, S3SSLCertificateError
-from .Utils import getBucketFromHostname
+from .Utils import getBucketFromHostname, deunicodise_s, unicodise_s
 
 
 
@@ -229,14 +230,22 @@ def __init__(self, id, hostname, ssl, cfg):
                 self.c = httplib.HTTPConnection(self.hostname, self.port)
                 debug(u'non-proxied HTTPConnection(%s, %s)', self.hostname, self.port)
         else:
+            headers = {}
+            proxy_hostname = cfg.proxy_host
+            if '@' in cfg.proxy_host:
+                credential, proxy_hostname = cfg.proxy_host.split('@')
+                # FIXME: Following line can't handle username or password including colon
+                proxy_username, proxy_password = credential.split(':')
+                headers['Proxy-Authorization'] = 'Basic ' + \
+                    unicodise_s(b64encode(deunicodise_s(('%s:%s' % (proxy_username, proxy_password)))))
             if ssl:
-                self.c = http_connection._https_connection(cfg.proxy_host, cfg.proxy_port)
+                self.c = http_connection._https_connection(proxy_hostname, cfg.proxy_port)
                 debug(u'proxied HTTPSConnection(%s, %s)', cfg.proxy_host, cfg.proxy_port)
                 port = self.port and self.port or 443
-                self.c.set_tunnel(self.hostname, port)
+                self.c.set_tunnel(self.hostname, port, headers)
                 debug(u'tunnel to %s, %s', self.hostname, port)
             else:
-                self.c = httplib.HTTPConnection(cfg.proxy_host, cfg.proxy_port)
+                self.c = httplib.HTTPConnection(proxy_hostname, cfg.proxy_port)
                 debug(u'proxied HTTPConnection(%s, %s)', cfg.proxy_host, cfg.proxy_port)
                 # No tunnel here for the moment
 

s3cmd

@@ -68,6 +68,12 @@ except ImportError:
     # python2 fallback code
     from distutils.spawn import find_executable as which
 
+try:
+    # python 3 support
+    from urlparse import urlparse
+except ImportError:
+    from urllib.parse import urlparse
+
 
 def output(message):
     sys.stdout.write(message + "\n")
@@ -2342,21 +2348,13 @@ def run_configure(config_file, args):
         ("gpg_passphrase", "Encryption password", "Encryption password is used to protect your files from reading\nby unauthorized persons while in transfer to S3"),
         ("gpg_command", "Path to GPG program"),
         ("use_https", "Use HTTPS protocol", "When using secure HTTPS protocol all communication with Amazon S3\nservers is protected from 3rd party eavesdropping. This method is\nslower than plain HTTP, and can only be proxied with Python 2.7 or newer"),
-        ("proxy_host", "HTTP Proxy server name", "On some networks all internet access must go through a HTTP proxy.\nTry setting it here if you can't connect to S3 directly"),
+        ("proxy_host", "username:[email protected]", "HTTP Proxy server name", "On some networks all internet access must go through a HTTP proxy.\nTry setting it here if you can't connect to S3 directly"),
         ("proxy_port", "HTTP Proxy server port"),
         ]
     ## Option-specfic defaults
     if getattr(cfg, "gpg_command") == "":
         setattr(cfg, "gpg_command", which("gpg"))
 
-    if getattr(cfg, "proxy_host") == "" and os.getenv("http_proxy"):
-        autodetected_encoding = locale.getpreferredencoding() or "UTF-8"
-        re_match=re.match(r"(http://)?([^:]+):(\d+)",
-                          unicodise_s(os.getenv("http_proxy"), autodetected_encoding))
-        if re_match:
-            setattr(cfg, "proxy_host", re_match.groups()[1])
-            setattr(cfg, "proxy_port", re_match.groups()[2])
-
     try:
         # Support for python3
         # raw_input only exists in py2 and was renamed to input in py3
@@ -2372,12 +2370,16 @@ def run_configure(config_file, args):
             for option in options:
                 prompt = option[1]
                 ## Option-specific handling
-                if option[0] == 'proxy_host' and getattr(cfg, 'use_https') == True and sys.hexversion < 0x02070000:
-                    setattr(cfg, option[0], "")
-                    continue
-                if option[0] == 'proxy_port' and getattr(cfg, 'proxy_host') == "":
-                    setattr(cfg, option[0], 0)
-                    continue
+                if option[0] == "proxy_host":
+                    autodetected_encoding = locale.getpreferredencoding() or "UTF-8"
+                    key = "https_proxy" if getattr(cfg, 'use_https') else "http_proxy"
+                    url = urlparse(unicodise_s(os.getenv(key), autodetected_encoding))
+                    if url.port is None:
+                        port = 80 if url.scheme == "http" else 443  # httplib supports HTTP(S) proxy only
+                    else:
+                        port = url.port
+                    setattr(cfg, "proxy_host", "%s:%s@%s" % (url.username, url.password, url.hostname))
+                    setattr(cfg, "proxy_port", port)
 
                 try:
                     val = getattr(cfg, option[0])