Renames log level enum values to not conflict with syslog #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I was just about to open my own PR for this for the same reason! Has this been forgotten about or does something more need to be done? |
LOG_DEBUG conflicts with another enum definition in syslog.h, which causes compilation errors when included. This renames the enum values to be prefixed with LOGC instead of LOG to avoid this
|
I haven't received any feedback, so not sure. I rebased my branch so feel free to use my fork |
|
@chiefnoah Thanks for doing this. Did you also have code to log to syslog? |
It's been awhile, but I believe I was trying to compile something with a library that used syslog, not use it directly myself. |
|
Hello, I found your pull-request useful and merged it to my fork ! Feel free to propose changes, thanks for your contribution 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOG_DEBUG conflicts with another enum definition in syslog.h,
which causes compilation errors when included. This renames
the enum values to be prefixed with LOGC instead of LOG to
avoid this.
This addresses #3.