Skip to content

Commit

Permalink
Fixed: Done button incorrectly shown in BottomSheet
Browse files Browse the repository at this point in the history
  • Loading branch information
rushisangani committed Dec 4, 2019
1 parent f29b7b8 commit c84630e
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ An elegant selection list or dropdown menu for iOS with single or multiple selec
- Provide header row as **Empty**, **All**, **None** or **Custom Text**
- Customizable design for UINavigationBar and UISearchBar

## What's new in 6.0.8
- Use **.bottomSheet** instead of '.actionSheet' to support themes in iOS 13.

## Requirements
```swift
iOS 9.0+ | Xcode 8.3+ | Swift 3.0+
Expand All @@ -30,7 +33,7 @@ iOS 9.0+ | Xcode 8.3+ | Swift 3.0+
### CocoaPods

```ruby
pod 'RSSelectionMenu' or pod 'RSSelectionMenu', '~> 6.0.7'
pod 'RSSelectionMenu' or pod 'RSSelectionMenu', '~> 6.0.8'
```

### Carthage
Expand Down
2 changes: 1 addition & 1 deletion RSSelectionMenu.podspec
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Pod::Spec.new do |s|

s.name = "RSSelectionMenu"
s.version = "6.0.7"
s.version = "6.0.8"

s.summary = "An elegant selection list or dropdown menu for iOS with single or multiple selections."
s.description = <<-DESC
Expand Down
Binary file not shown.
4 changes: 2 additions & 2 deletions RSSelectionMenu/RSSelectionMenu.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MARKETING_VERSION = 6.0.7;
MARKETING_VERSION = 6.0.8;
PRODUCT_BUNDLE_IDENTIFIER = com.rushi.RSSelectionMenu;
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
SKIP_INSTALL = YES;
Expand All @@ -406,7 +406,7 @@
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MARKETING_VERSION = 6.0.7;
MARKETING_VERSION = 6.0.8;
PRODUCT_BUNDLE_IDENTIFIER = com.rushi.RSSelectionMenu;
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
SKIP_INSTALL = YES;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ extension RSSelectionMenu {

// add done action
if (tableView?.selectionStyle == .multiple || !self.dismissAutomatically || style == .actionSheet) {
alertController.addAction(doneAction)
if case .actionSheet = menuPresentationStyle {
alertController.addAction(doneAction)
}
}

let viewHeight = height ?? 350
Expand Down

0 comments on commit c84630e

Please sign in to comment.