-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update FileWorkspace logic to use pull request refs only when PR number is specified #4851
Open
marcus-rev
wants to merge
7
commits into
runatlantis:main
Choose a base branch
from
marcus-rev:fix-clone-for-github-app-no-pr-number
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: update FileWorkspace logic to use pull request refs only when PR number is specified #4851
marcus-rev
wants to merge
7
commits into
runatlantis:main
from
marcus-rev:fix-clone-for-github-app-no-pr-number
Commits on Aug 16, 2024
-
- Updating FileWorkspace.GithubAppEnabled comment to specify updated …
…logic around prNumber=0. - Updating mergeToBaseBranch to only look for PR refs if GitHub app is enabled _and_ the plan/apply includes a PR number, which can optionally be 0.
Configuration menu - View commit details
-
Copy full SHA for 0110a15 - Browse repository at this point
Copy the full SHA 0110a15View commit details
Commits on Aug 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 180cd15 - Browse repository at this point
Copy the full SHA 180cd15View commit details
Commits on Aug 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ceac026 - Browse repository at this point
Copy the full SHA ceac026View commit details
Commits on Aug 22, 2024
-
- Updating another location that should check if there's a PR number …
…included in the API call. When checking out a branch directly without a PR number, HEAD should be fine vs HEAD^2.
Configuration menu - View commit details
-
Copy full SHA for dd5d8a9 - Browse repository at this point
Copy the full SHA dd5d8a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 406d905 - Browse repository at this point
Copy the full SHA 406d905View commit details -
- Skipping VCS update when there is no pull request associated with a…
… plan. This eliminates the following error in Atlantis server: 422 Validation Failed [{Resource:Status Field:sha Code:custom Message:sha must be a 40 character SHA1}]
Configuration menu - View commit details
-
Copy full SHA for e7e5794 - Browse repository at this point
Copy the full SHA e7e5794View commit details
Commits on Nov 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc445e1 - Browse repository at this point
Copy the full SHA fc445e1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.