Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependent: :destroy #508

Closed
wants to merge 2 commits into from
Closed

Support dependent: :destroy #508

wants to merge 2 commits into from

Conversation

pomartel
Copy link

@pomartel pomartel commented Feb 8, 2021

Fixes #507

@pomartel
Copy link
Author

pomartel commented Feb 9, 2021

This is more complicated than I first thought. Counter caches and permanent deletes also need to be handled correctly. I started implementing a custom DestroyAssociationAsyncJob but now I see that the gem maintainers don't accept new features so I will close this PR for now but I would be interested in digging deeper if there is a chance this feature can be accepted.

@pomartel pomartel closed this Feb 9, 2021
@mathieujobin
Copy link
Collaborator

@pomartel I am definitely interesting seeing destroy_async support in paranoia

@pomartel
Copy link
Author

Sorry @mathieujobin, I opted to destroy records asynchronously in my own code instead (using a background job).

@mathieujobin
Copy link
Collaborator

No problem

It sounds like a good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Association is not restored when using dependent: :destroy_async
2 participants