CaseContact validates usage and spec changes - case contact form prep #6061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejonroberts
force-pushed
the
contact-form-refactor-prep-spec-changes
branch
from
8309982
to
5728305
Compare
thejonroberts
changed the title
thejonroberts
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
2 tasks
thejonroberts
commented
Sep 25, 2024
| @@ -90,7 +90,7 @@ | |||
| member do | |||
| post :restore | |||
| end | |||
| resources :form, controller: "case_contacts/form" | |||
| resources :form, controller: "case_contacts/form", only: %i[show update] | |||
There was a problem hiding this comment.
these are the only actions in the controller, so this is not a behavioral change (except preventing controller errors)
thejonroberts
commented
Sep 25, 2024
thejonroberts
commented
Sep 25, 2024
thejonroberts
commented
Sep 26, 2024
elasticspoon
approved these changes
Sep 26, 2024
Comment on lines
-49
to
+50
| trait :with_disasllow_reimbursement do | ||
| trait :with_disallow_reimbursement do |
| @@ -13,7 +13,7 @@ | |||
| association :creator, factory: :user | |||
| casa_case | |||
|
|
|||
| contact_types { [create(:contact_type)] } | |||
| contact_types { [association(:contact_type)] } | |||
There was a problem hiding this comment.
not familiar with this. what does it do vs just the create?
There was a problem hiding this comment.
It will play a little nicer with build/build_stubbed according to the docs, so fewer db hits in those situations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Some changes that I could pull out of #6048 -- Mostly just tangential improvements I made that aren't directly required.
Changes some custom validations to use standard
validatesmethods. Adds some conveniences to factories, and some resulting minor spec changes.