Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at updating en/documentation/index.md #3427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zenspider
Copy link

@zenspider zenspider commented Nov 20, 2024

main changes:

LOTS of bitrot on this page. Most has been removed but some have been
moved down to an "older" section.

Revamped editor section to include difficulty "levels"

Added a bunch of sections and links mostly derived from the ruby
discord's #library.

This fixes #3426

@zenspider zenspider requested a review from a team as a code owner November 20, 2024 05:43
LOTS of bitrot on this page. Most has been removed but some have been
moved down to an "older" section.
@kaya3
Copy link

kaya3 commented Nov 21, 2024

From my (new to Ruby) perspective, this looks like a massive improvement.

Having just completed the Ruby Koans, I can confirm that they are still correct for Ruby 3.3.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a HUGE improvement ❤️
Just a few suggestions 🙂

[The Well-Grounded Rubyist][grounded]
: A tutorial that begins with your first Ruby program and takes you all the way to sophisticated topics like reflection, threading, and recursion.

#### Adept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a non-native English speaker, I think Adept is a relatively rare choice of word. Maybe Advanced will be more approachable?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Experienced would be better? Advanced and Expert are closer in my mind than Adept/Experienced and Expert are.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intermediate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intermediate sounds good to me 👍

* Expert
* [Emacs][20] with [Ruby mode][21] or [Enhanced Ruby mode][enh-ruby-mode]
* [Vim][25] with [vim-ruby][26] plugin
* [NeoVim][neovim]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need or should pair editors with experience levels. For example, I started writing Ruby with Vim, then switched to NeoVim for like 6 years, and switched to VS Code like 2 years ago.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea is from an approachability standpoint instead of an end user skill level standpoint.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I meant this more about learning curve of the editor

Comment on lines 158 to 159
All of these editors support the Language Server Protocol (LSP). You
can use Shopify's [ruby-lsp][ruby-lsp] plugin for ruby support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All of these editors support the Language Server Protocol (LSP). You
can use Shopify's [ruby-lsp][ruby-lsp] plugin for ruby support.
All of these editors support the Language Server Protocol (LSP), either by default or through their LSP plugins.
Shopify's [ruby-lsp][ruby-lsp] is one of the most popular language servers for Ruby and [supports all of the above editors](https://shopify.github.io/ruby-lsp/editors.html)

@zenspider
Copy link
Author

Pushed some edits based on feedback.

Please let me squash and reword before merge (assuming).

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few nitpicks but LGTM 👍

: The ruby quick reference

[rubyreferences][43]
: A full language reference + detailed language changelog. Fantastic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spacing:

Suggested change
: A full language reference + detailed language changelog. Fantastic.
: A full language reference + detailed language changelog. Fantastic.

While I agree it's a fantastic work, it feels a bit odd to add Fantastic. in its description?

* [Zed][zed]
* Intermediate
* [RubyMine][27] (paid)
* Expert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe "difficult" can fit the tooling context better than "expert"?

Suggested change
* Expert
* Difficult

[Airbnb][48]
: AirBNB's Ruby style guide

[w3resource][49]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and for adding helpful links 🙌🏻 I noticed this one has significant number of ads (screenshot below). While the content looks valuable, I wonder if we should consider whether this is a good addition to be on the documentation page on the Ruby official website 🤔

CleanShot 2024-11-25 at 21 51 56@2x

Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working to improve this.

#### Beginner

[Programming Ruby 3.3][pickaxe]
: The seminal work on Ruby in English. Recently updated to ruby 3.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: The seminal work on Ruby in English. Recently updated to ruby 3.3.
: The seminal work on Ruby in English. Recently updated to Ruby 3.3.

#### Intermediate

[Practical OOD in Ruby (POODR)][poodr]
: A programmers tale about how to write object-oriented code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: A programmers tale about how to write object-oriented code.
: A programmer's tale about how to write object-oriented code.

: Explains metaprogramming in a down-to-earth style.

[Ruby Under a Microscope (RUM)][microscope]
: An illustrated guide to ruby internals.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: An illustrated guide to ruby internals.
: An illustrated guide to Ruby internals.

### Style Guides

[rubystyle.guide][44]
: Rubocop's Ruby style guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: Rubocop's Ruby style guide
: RuboCop's Ruby style guide

: Gitlab's Ruby style guide

[Airbnb][48]
: AirBNB's Ruby style guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: AirBNB's Ruby style guide
: Airbnb's Ruby style guide

: AirBNB's Ruby style guide

[w3resource][49]
: W3's Ruby style guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest dropping this, it seems to be a copy-paste of Airbnb's guide.

: online API documentation

[Ruby QuickRef][42]
: The ruby quick reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: The ruby quick reference
: The Ruby quick reference

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add that this is for both the language and the standard library. Many references for other languages cover just one or the other.

Comment on lines +194 to +196
[Programming Ruby][9]
: The seminal work on Ruby in English, this first edition of the
[Pragmatic Programmers’ book][10] is available for free online.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Programming Ruby][9]
: The seminal work on Ruby in English, this first edition of the
[Pragmatic Programmers’ book][10] is available for free online.
[Programming Ruby][9]
: The first edition of this seminal work on Ruby in English is available for free online.

The current edition is already linked to in the Books section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Outdated "getting started" links
6 participants