Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Chicory to 1.0.0-M1 #3210

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Bump Chicory to 1.0.0-M1 #3210

merged 1 commit into from
Nov 4, 2024

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Nov 4, 2024

👋 we just released a first Milestone for Chicory, since it's breaking in many ways, I wanted to check that everything remains aligned.

Notes:

  • we now have a wasi implementation, so, some more code-paths should be usable (for filesystem operation we suggest to use Jimfs though)
  • we have a new AOT compiler, I would be happy to set up here, basically we can ship a "ready to run" Jar package for Prism, wdyt? (example: wabt)

@kddnewton
Copy link
Collaborator

Yeah that sounds great! Do you mean add it as an artifact after the build kind of thing? @enebo would you be able to use that?

@kddnewton kddnewton merged commit 0e0ae6f into ruby:main Nov 4, 2024
55 checks passed
@andreaTP
Copy link
Contributor Author

andreaTP commented Nov 4, 2024

I think @enebo will be able to use it easily, I would require some help in setting up the automated release CI,.
If that's good for you @kddnewton I'll move forward in the next few days. 😊

BTW, a wonderful experience contributing to this repo! Great job!

@kddnewton
Copy link
Collaborator

Yeah that's fine. I think just uploading it as an artifact to the build to start would be good. That's what we have for JS and it works fine for now

- uses: actions/upload-artifact@v3
with:
name: prism.wasm
path: javascript/src/prism.wasm

@andreaTP
Copy link
Contributor Author

andreaTP commented Nov 6, 2024

Thanks for the feedback, @kddnewton , two comments here:

  • I was aiming to publish a full-fledged Jar to Maven Central as we are already uploading the wasm file to artifacts
  • I need more time to finalize this proposal as we are hitting some Java bytecode limitations (we are already working on fixing the issue)

All in all, the current setup is fine for now, I'll come up with something when we are ready 🙂

@kddnewton
Copy link
Collaborator

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants