Use normal method definition instead of attr_reader in RBI files
#2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapioca currently rewrites `attr_reader` methods in RBI files to normal method definitions when merging signatures, but doesn't include the annotations in the merged result. Related issue: Shopify/tapioca#1709 This means that current methods typed with `attr_reader` in RBI files are actually untyped in the merged RBI files. So this commit declares those methods with normal method definitions in the RBI files to work around this issue.
kddnewton
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tapioca currently rewrites
attr_readermethods in RBI files to normal method definitions when merging signatures, but doesn't include the annotations in the merged result.Related issue: Shopify/tapioca#1709
This means that current methods typed with
attr_readerin RBI files are actually untyped in the merged RBI files. So this commit declares those methods with normal method definitions in the RBI files to work around this issue.