[Fix #421] Fix false positives for Performance/TimesMap
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positives_for_performance_times_map
branch
from
5ad1265
to
52c999a
Compare
koic
changed the title
Performance/TimesMapPerformance/TimesMap
ydakuka
reviewed
Dec 12, 2023
| RUBY | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
What about this case?
it 'does not register an offense and corrects' do
expect_no_offenses(<<~RUBY, method: method)
foo&.times&.#{method} { |i| i.to_s }
RUBY
endThere was a problem hiding this comment.
Sure, I've fixed that case.
Fixes rubocop#421. This PR fixes false positives for `Performance/TimesMap` with a block with safe navigation call for nil literal. It does not have a changelog entry because it is a patch to a feature that has not been released yet.
koic
force-pushed
the
fix_false_positives_for_performance_times_map
branch
from
52c999a
to
68632dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421.
This PR fixes false positives for
Performance/TimesMapwith a block with safe navigation call for nil literal.It does not have a changelog entry because it is a patch to a feature that has not been released yet.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.