Don't deschedule perf counters #1812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of not descheduling perf counters
Instead use the ioctls. In the pingpong test case this gives 15-20% performance improvement for recording.
|
Merged. Thanks!!! |
|
One further improvement would be to avoid disabling and reenabling performance counters in more cases. In theory we shouldn't need to do it at all, we should only need to reset the period sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases the first two commits of #1754 (and detects old kernels where IOC_PERIOD is broken). As noted in #1778, this gives a decent amount of performance improvement in context switch dominated test cases. There may be additional incremental improvements possible, but this gives the bulk of the savings in a relatively straightforward manner.