-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wslbridge-backend path from command #25
Conversation
You already closed #23? I don't think I understand why this option is needed. You've run into a situation where the two files can't be in the same directory, I guess? I'd prefer something more descriptive than It looks like your |
Even with your change, Are you trying to package multiple backends to accommodate different distributions, maybe? I've been thinking lately that maybe the backend should be statically linked so it works with non-glibc distributions... |
replace `-p` option with `-b` or `--backend` option in `getopt_long()`. And add the path in findBackendProgram() function.
May you please accept these changes? This helps in wsltty.appx project. |
Why does the wsltty.appx project need the flag? |
Because in UWP environment the backend cannot be executed. So it need to copied in LocalAppData. And with that option I can execute backend from that path. Also with this option users have no restriction to put both files in same directory. |
Ok, that makes sense. I'll try to look at the change soon. Maybe I'll just add a |
Not necessary. I already have this behavior written. I'll push it within a day:
It takes a path to the file rather than a path to a directory containing the file. I assume that's not an issue. |
It's just the normal Cygwin rules. |
Apparently this is useful for the appx bundling of wsltty. That project copies wslbridge.exe and wslbridge-backend to a separate directory to get around a permissions issue, and it'd be better if only the backend were copied. Fixes #23 See #25 See mintty/wsltty#63
Should I close this PR? |
Yes, please close it. |
I've added the
-p
option to add wslbridge-backend path. With that option, the backend find can be put in anywhere.