Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke user's default shell #17

Open
mintty opened this issue Oct 10, 2017 · 6 comments
Open

Invoke user's default shell #17

mintty opened this issue Oct 10, 2017 · 6 comments

Comments

@mintty
Copy link

mintty commented Oct 10, 2017

As discussed in #14, there are two alternative launchers, bash.exe and wsl.exe.
Apparently, with recent updates, wsl.exe when run without program parameters, invokes the default shell configured in WSL, while bash.exe can't. Home and guid parameters (~, {...}) do not interfere.
That would be a good reason to switch to wsl.exe by default, also solving mintty/wsltty#16.

@rprichard
Copy link
Owner

When wslbridge invokes bash.exe, it directs it to run wslbridge-backend, overriding whatever shell bash.exe would have invoked by default. wslbridge is responsible for the /bin/bash default, not the WSL bash.exe wrapper.

I agree that it should use the user's configured shell rather than /bin/bash. Maybe it's as easy as having wslbridge-backend call getpwnam/getpwuid and look at the pw_shell field.

@fpqc
Copy link

fpqc commented Nov 7, 2017

@rprichard If you launch via wsl.exe rather than bash.exe, maybe you can just inherit from the environment variables (wsl.exe I think does the getpwnam/getpwuid)

@sillykelvin
Copy link

Anything new on this issue?

@rprichard
Copy link
Owner

This issue was fixed in 34ec0e4, but the fix isn't in an official release yet.

@sillykelvin
Copy link

@rprichard Thanks for your great job! No release is fine, I will build from master branch myself. :-p

@er1c
Copy link

er1c commented Dec 5, 2018

I'm interested in this default shell functionality too - I think I'm currently on the preview release - is there a version of binary conemu/wslbridge that has this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants