Revert recent %_root_prefix macro addition (RhBug:2233454) #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cececfb introduced %_root_prefix macro but this clashes with pre-existing use in scl-utils: https://bugzilla.redhat.com/show_bug.cgi?id=223345: Just query the value from pkg-config if available and otherwise use hardcoded value pointing to /usr instead. We don't need an intermediate global macro for this.
Commit c7fd9fe introduced %_sysusersdir into the group of global configure-related macros but that's not what it's related to at all, it's only related to our sysusers integration feature. Move it where it really belongs.
|
Note that even if scl-utils was changed to test for something else, this clash has a potential of breaking rpm instead. scl-utils was there first by a long shot, we better let them have the macro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit cececfb introduced %_root_prefix macro but this unnecessarily breaks widespread use in scl-utils: https://bugzilla.redhat.com/show_bug.cgi?id=2233454
Just query the value from pkg-config if available and otherwise use hardcoded value pointing to /usr instead. We don't need an intermediate global macro for this.