Add a nice wrapper for get_sys_info

[nahla-nee]

Implements a nice safe wrapper for get_sys_info as described in #839 .

[thejpster]

Thank you for this PR. In general it looks great!

I would like to see an example of using this API though.

[nahla-nee]

Sure! And I'll go ahead make the suggestions changes too. I'll probably do that by tonight (us time). Do you want the example to be added to the existing rom function example? And if so do you want it to replace the existing one?

[thejpster]

I'm ok with it going into the existing example binary. I'm not sure if we need to leave an example of the old API or if we expect people to only use the new one.

[nahla-nee]

I also went ahead and added some more documentation. It probably could use more work cause I was in a bit of a rush but it should make things easier to read. I also elaborated on the existing examples since we don't have settle for printing the hex representation of the bytes get_sys_info gives back now.

[thejpster]

These nested matches can be collapsed.

[nahla-nee]

I'll get working on those changes. It just occurred to me that I didn't add an api for get_sys_info_ns. Do you want that added as well?

[nahla-nee]

I held off on adding the ns version of the api for now but its ready (https://github.com/nahla-nee/rp-hal/tree/feature/get_sys_info_ns_api) for a pr whenever if you did want it included as well

[thejpster]

I'll get working on those changes. It just occurred to me that I didn't add an api for get_sys_info_ns. Do you want that added as well?

I guess it would be good to have that, although I haven't written much NS software for the 2350.

Not a blocker for this PR though.

[thejpster]

Looks great! Thank you.

[thejpster]

ah, needs a cargo fmt please

[nahla-nee]

I went ahead and merged the NS branch into my current branch. Hopefully that's not an issue, I glanced at the notification I got about your message which cut off the part about it not being a blocker. And cargo fmt has been ran 😅 forgot i made changes to the examples folder and only ran it in the hal folder

[thejpster]

Before:

get_sys_info(CHIP_INFO/0x0001) -> 4
        Supported Flags: 0x0001
        RP2350 Package ID: 0x00000000
        RP2350 Device ID : 0x2d92c1e1
        RP2350 Wafer ID  : 0xb6d90d05
get_sys_info(CPU_INFO/0x0004) -> 2
        Supported Flags: 0x0004
        CPU Architecture: Arm
get_sys_info(FLASH_DEV_INFO/0x0008) -> 2
        Supported Flags: 0x0008
        CS0 Size: 16M
        CS1 Size: None
get_sys_info(BOOT_RANDOM/0x0010) -> 5
        Supported Flags: 0x0010
        A random number: 0xcfb87af017b6a85f4c1de260cef281e3

After:

get_sys_info(CHIP_INFO/0x0001)
        RP2350 Package ID: 0x00000000
        RP2350 Device ID : 0x2d92c1e1
        RP2350 Wafer ID  : 0xb6d90d05
get_sys_info(CPU_INFO/0x0004)
        CPU Architecture: Arm
get_sys_info(FLASH_DEV_INFO/0x0008)
        CS1 GPIO: 0
        D8H Erase Supported: false
        CS0 Size: 16M
        CS1 Size: None
get_sys_info(BOOT_RANDOM/0x0010)
        A random number: 0x6713d047488e82a24dc9660817f0f669

Looks great!