Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortened code lines (partly using yapf), wrapped comments #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deeplook
Copy link

@deeplook deeplook commented Jan 5, 2017

This PR mainly wraps comment lines manually, shortens code lines and applies some readability improvements mostly as suggested by yapf. This helps generate a PDF version with index cards like in my fork. But as usual in such cases, the result is sometimes a bit of a compromise.

@rougier
Copy link
Owner

rougier commented Jan 5, 2017

Looks good to me.

@deeplook
Copy link
Author

deeplook commented Jan 5, 2017

This is the respective PDF output with appropriate fonts: https://github.com/deeplook/numpy-100/blob/master/100%20Numpy%20exercises.pdf

I feel like the MD parser needs to be more general to accommodate for cards showing arbitrary sequences of paragraphs and code, like in Jupyter notebooks. In fact, I had a go at this before with ReST and dedicated directives. I might give it another go. Would you be open to switching from MD to ReST?

@rougier
Copy link
Owner

rougier commented Jan 5, 2017

Not really but we can have a rst version alongside the md version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants