Update the launch file to work with modern joy. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]>
ahcorde
approved these changes
Sep 6, 2024
|
@clalancette do we need to backport this ? |
Yeah, we should. |
|
@Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md
mergify bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md
clalancette
added a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md
clalancette
added a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md
clalancette
added a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md Co-authored-by: Chris Lalancette <[email protected]>
clalancette
added a commit
that referenced
this pull request
Sep 6, 2024
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform). Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e4856e4) # Conflicts: # README.md Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should use "device_id" (not "dev") as the parameter, and the parameter should be a number, not a path (this is effectively the SDL device number, which is cross-platform).