Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to build on BSD #142

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Don't try to build on BSD #142

merged 1 commit into from
Nov 21, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 8, 2024

The 'BSD' variable was added in CMake 3.25. Note that variables which are not defined will evaluate to 'False', so this shouldn't regress platforms using CMake versions older than 3.25.

The 'BSD' variable was added in CMake 3.25. Note that variables which
are not defined will evaluate to 'False', so this shouldn't regress
platforms using CMake versions older than 3.25.

Signed-off-by: Scott K Logan <[email protected]>
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@fujitatomoya
Copy link
Contributor

Pulls: #142
Gist: https://gist.githubusercontent.com/fujitatomoya/3ff1c9ca432faf41f6185dc26ad84e18/raw/7c129397396e04b13b29cc6902438e3bdde0fbad/ros2.repos
BUILD args: --packages-up-to lttngpy test_tracetools tracetools
TEST args: --packages-select lttngpy test_tracetools tracetools
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14801

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 60170d7 into rolling Nov 21, 2024
8 of 9 checks passed
@christophebedard christophebedard deleted the cottsay/bsd branch November 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants