Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency on pkg-config to lttngpy (backport #130) #136

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 25, 2024

The lttngpy package depends on pkg-config for finding the lttng-ctl libraries, but didn't list it in its package.xml. Without the explicit dependency, some strict build environments will fail.


This is an automatic backport of pull request #130 done by Mergify.

Signed-off-by: Nathan Wiebe Neufeldt <[email protected]>
(cherry picked from commit a866b9c)
@ahcorde
Copy link
Contributor

ahcorde commented Sep 25, 2024

Pulls: #136
Gist: https://gist.githubusercontent.com/ahcorde/b357fdc9eb563229cd2e5d92a48229fb/raw/4381359917eb5bac74d71490d17ca9c278e5a2f4/ros2.repos
BUILD args: --packages-above-and-dependencies lttngpy --packages-above-and-dependencies lttngpy
TEST args: --packages-above lttngpy --packages-above lttngpy
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14608

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 73a7e6d into jazzy Sep 25, 2024
8 of 9 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-130 branch September 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants