tp_call.h fix field type for tracepoint event rclcpp_ring_buffer_enqueue #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattis Kieffer <[email protected]>
christophebedard
approved these changes
May 21, 2024
|
|
The failures on aarch64 are due to Mimick and are expected, so this is good. Thanks for the fix! |
Closed
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
…117) Signed-off-by: Mattis Kieffer <[email protected]> (cherry picked from commit 7e8d42e)
christophebedard
pushed a commit
that referenced
this pull request
Jun 10, 2024
…117) (#119) Signed-off-by: Mattis Kieffer <[email protected]> (cherry picked from commit 7e8d42e) Co-authored-by: Mattis Kieffer <[email protected]>
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
…117) Signed-off-by: Mattis Kieffer <[email protected]> (cherry picked from commit 7e8d42e)
christophebedard
pushed a commit
that referenced
this pull request
Jun 15, 2024
…117) (#121) Signed-off-by: Mattis Kieffer <[email protected]> (cherry picked from commit 7e8d42e) Co-authored-by: Mattis Kieffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request:
While trying to compile ros2 on my system with gcc-14 i got an integer conversion warning causing a compilation failure:
Proposed fix:
As far as i see it, the field type should match the argument type in this case.
After applying the proposed fix locally, the compilation succeeded.