Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2 listener cpp tutorial: minor syntax/wording improvements #4434

Merged
merged 2 commits into from
May 15, 2024

Conversation

ottojo
Copy link
Contributor

@ottojo ottojo commented May 13, 2024

some changes i think might improve readability, as discovered in osrf/ros2_test_cases#1176.
i would have liked to add a link to a more generic "tf concepts" page, but i didnt find anything satisfactory. i really like tho the first two paragraphs in #4235 which i found very insightful especially around the question of target/source terminology and frame order.

@clalancette
Copy link
Contributor

i would have liked to add a link to a more generic "tf concepts" page, but i didnt find anything satisfactory. i really like tho the first two paragraphs in #4235 which i found very insightful especially around the question of target/source terminology and frame order.

We have http://docs.ros.org/en/rolling/Concepts/Intermediate/About-Tf2.html , though I admit it is pretty light on details. Still, I think it would make sense to link there, and then possibly expand that later. What do you think?

@ottojo
Copy link
Contributor Author

ottojo commented May 14, 2024

i would have liked to add a link to a more generic "tf concepts" page, but i didnt find anything satisfactory. i really like tho the first two paragraphs in #4235 which i found very insightful especially around the question of target/source terminology and frame order.

We have http://docs.ros.org/en/rolling/Concepts/Intermediate/About-Tf2.html , though I admit it is pretty light on details. Still, I think it would make sense to link there, and then possibly expand that later. What do you think?

sounds good to me, i added a link to that page!

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the update!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label May 15, 2024
@clalancette clalancette merged commit bfbd9bc into ros2:rolling May 15, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request May 15, 2024
* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)
mergify bot pushed a commit that referenced this pull request May 15, 2024
* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

# Conflicts:
#	source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
mergify bot pushed a commit that referenced this pull request May 15, 2024
* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

# Conflicts:
#	source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
clalancette pushed a commit that referenced this pull request May 15, 2024
…4460)

* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

Co-authored-by: Jonas Otto <[email protected]>
clalancette pushed a commit that referenced this pull request May 15, 2024
* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

# Conflicts:
#	source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
clalancette pushed a commit that referenced this pull request May 15, 2024
* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

# Conflicts:
#	source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
clalancette pushed a commit that referenced this pull request May 15, 2024
…4461)

* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

Co-authored-by: Jonas Otto <[email protected]>
clalancette pushed a commit that referenced this pull request May 15, 2024
…4462)

* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

Co-authored-by: Jonas Otto <[email protected]>
@ottojo ottojo deleted the tf2_listener_cpp_fixes branch May 16, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants