-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf2 listener cpp tutorial: minor syntax/wording improvements #4434
Conversation
We have http://docs.ros.org/en/rolling/Concepts/Intermediate/About-Tf2.html , though I admit it is pretty light on details. Still, I think it would make sense to link there, and then possibly expand that later. What do you think? |
sounds good to me, i added a link to that page! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the update!
* tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc)
* tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) # Conflicts: # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
* tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) # Conflicts: # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
…4460) * tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) Co-authored-by: Jonas Otto <[email protected]>
* tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) # Conflicts: # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
* tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) # Conflicts: # source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
…4461) * tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) Co-authored-by: Jonas Otto <[email protected]>
…4462) * tf2 listener cpp tutorial: minor syntax/wording improvements * add link to tf2 concepts page (cherry picked from commit bfbd9bc) Co-authored-by: Jonas Otto <[email protected]>
some changes i think might improve readability, as discovered in osrf/ros2_test_cases#1176.
i would have liked to add a link to a more generic "tf concepts" page, but i didnt find anything satisfactory. i really like tho the first two paragraphs in #4235 which i found very insightful especially around the question of target/source terminology and frame order.