Skip to content

Commit

Permalink
verify client gid uniqueness for a single service event. (#2636)
Browse files Browse the repository at this point in the history
Signed-off-by: Tomoya Fujita <[email protected]>
  • Loading branch information
fujitatomoya authored Oct 1, 2024
1 parent 51dfdc3 commit 2813045
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions rclcpp/test/rclcpp/test_service_introspection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,20 @@ TEST_F(TestServiceIntrospection, service_introspection_nominal)
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::REQUEST_SENT]->info.client_gid));
// TODO(@fujitatomoya): Remove this if statement once other rmw implementations support test.
// Only rmw_connextdds can pass this test requirement for now.
// See more details for https://github.com/ros2/rmw/issues/357
if (std::string(rmw_get_implementation_identifier()).find("rmw_connextdds") == 0) {
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::REQUEST_RECEIVED]->info.client_gid));
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::RESPONSE_SENT]->info.client_gid));
}
ASSERT_THAT(
client_gid_arr,
testing::Eq(event_map[ServiceEventInfo::RESPONSE_RECEIVED]->info.client_gid));

ASSERT_EQ(
event_map[ServiceEventInfo::REQUEST_SENT]->info.sequence_number,
Expand Down

0 comments on commit 2813045

Please sign in to comment.