python expressions substitution include names of all parents for specified modules #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zflat
requested review from
adityapande-1995,
methylDragon and
wjwwood
as code owners
zflat
force-pushed
the
python_expression_packaged_modules
branch
from
ea7abf8
to
6024df4
Compare
|
@adityapande-1995 Can I please get a review? |
clalancette
requested changes
Aug 10, 2023
Thanks @clalancette for the fix to the copy & paste error. Much better to have an appropriate failure reason reported. |
zflat
force-pushed
the
python_expression_packaged_modules
branch
from
424fd5e
to
815b5f7
Compare
Signed-off-by: William Wedler <[email protected]>
zflat
force-pushed
the
python_expression_packaged_modules
branch
from
815b5f7
to
7c3eac6
Compare
clalancette
approved these changes
Aug 22, 2023
|
CI:
|
|
So it looks like this caused a hang in the launch tests on all platforms. @zflat Can you take a look? It may the case that this just needs a rebase, but also please try to run the tests locally and make sure that they pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the python expression substitution to help with specifying python modules that are within a package.
Addresses issue #687