-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install liblttng-ctl-dev instead of python3-lttng in Rolling #725
Install liblttng-ctl-dev instead of python3-lttng in Rolling #725
Conversation
The corresponding package on RHEL9 is |
148bff3
to
ece6dd1
Compare
I updated |
@cottsay can you force-push my PR branch to this repo so that I can test the RHEL CI job? Thank you! |
He's OOO, I pushed it. |
Looks like I can't re-build the Docker image with RHEL/EL 9.2 due to a workaround for #727. Using 9.1 results in the failure described in #727: https://ci.ros2.org/job/ci_linux-rhel/517/. I guess we'll have to wait for this to be fixed. |
@christophebedard yes momentarily the 9.2 image is pinned to a stale one with the working dependencies for and all other options of building on RHEL 9 are going to result on failures due to the issue linked above. |
ece6dd1
to
3f2b0ff
Compare
We're still not quite to the place where we can take this; we first need to revert the 9.2-pinned PR (#728) and ensure everything works. Before we do that, we need to merge in ros-visualization/python_qt_binding#130 . But we are getting closer :). |
Thanks for the update! Looks like #728 has been reverted (#732) and ros-visualization/python_qt_binding#130 has been merged. Are we okay to proceed? |
@christophebedard Yes, Chris was able to unblock the RHEL situation. You should be unblocked here to run ci again to test your changes. |
Signed-off-by: Christophe Bedard <[email protected]>
3f2b0ff
to
c9e8670
Compare
Thanks! Would you (or anyone) mind force-pushing my branch to this repo so that I can (re)run a RHEL job? |
Latest changes force pushed on |
Looking good now, see new CI (including RHEL) at ros2/ros2_tracing#81 (comment). This is ready for a final review. |
This should be ready to be merged. |
@christophebedard Am I correct in thinking that this needs to be merged in concert with ros2/ros2_tracing#81 , so that Rolling nightlies continue to build? |
Indeed! I can't merge this PR but I can merge the |
@clalancette could you merge this PR? Then right after I can merge ros2/ros2_tracing#81. |
I'm just going to go ahead and merge in both. |
Required for ros2/ros2_tracing#81
We need
liblttng-ctl-dev
and can droppython3-lttng
in Rolling. We still needpython3-lttng
in Iron, though.Note that RHEL has
liblttng-ctl
version 2.12.11, while Ubuntu has 2.13.x.