Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install liblttng-ctl-dev instead of python3-lttng in Rolling #725

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Nov 7, 2023

Required for ros2/ros2_tracing#81

We need liblttng-ctl-dev and can drop python3-lttng in Rolling. We still need python3-lttng in Iron, though.

Note that RHEL has liblttng-ctl version 2.12.11, while Ubuntu has 2.13.x.

@cottsay
Copy link
Member

cottsay commented Nov 7, 2023

The corresponding package on RHEL9 is lttng-tools-devel - please update Dockerfile-RHEL appropriately.

@christophebedard christophebedard force-pushed the christophebedard/install-liblttng-ctl-dev branch from 148bff3 to ece6dd1 Compare November 8, 2023 17:17
@christophebedard
Copy link
Member Author

christophebedard commented Nov 8, 2023

I updated Dockerfile-RHEL. We should also probably test a RHEL CI build with the same settings as ros2/ros2_tracing#81 (comment) (I can't push the branch to this repo, though)

@christophebedard
Copy link
Member Author

christophebedard commented Nov 15, 2023

@cottsay can you force-push my PR branch to this repo so that I can test the RHEL CI job? Thank you!

@mjcarroll
Copy link
Member

@cottsay can you force-push my PR branch to this repo so that I can test the RHEL CI job?

He's OOO, I pushed it.

@christophebedard
Copy link
Member Author

christophebedard commented Nov 20, 2023

Looks like I can't re-build the Docker image with RHEL/EL 9.2 due to a workaround for #727. Using 9.1 results in the failure described in #727: https://ci.ros2.org/job/ci_linux-rhel/517/. I guess we'll have to wait for this to be fixed.

@claraberendsen
Copy link
Contributor

@christophebedard yes momentarily the 9.2 image is pinned to a stale one with the working dependencies for pyside2

and all other options of building on RHEL 9 are going to result on failures due to the issue linked above.
For now sadly until upstream EPEL dependencies breaks are rebuilt for 9.3 and we can move the ci to use the new AlmaLinux 9.3 there is no easy way to change a dependency.

@christophebedard christophebedard force-pushed the christophebedard/install-liblttng-ctl-dev branch from ece6dd1 to 3f2b0ff Compare December 7, 2023 18:39
@clalancette
Copy link
Contributor

We're still not quite to the place where we can take this; we first need to revert the 9.2-pinned PR (#728) and ensure everything works. Before we do that, we need to merge in ros-visualization/python_qt_binding#130 . But we are getting closer :).

@christophebedard
Copy link
Member Author

Thanks for the update!

Looks like #728 has been reverted (#732) and ros-visualization/python_qt_binding#130 has been merged. Are we okay to proceed?

@claraberendsen
Copy link
Contributor

@christophebedard Yes, Chris was able to unblock the RHEL situation. You should be unblocked here to run ci again to test your changes.

@christophebedard christophebedard force-pushed the christophebedard/install-liblttng-ctl-dev branch from 3f2b0ff to c9e8670 Compare December 13, 2023 21:27
@christophebedard
Copy link
Member Author

christophebedard commented Dec 13, 2023

Thanks! Would you (or anyone) mind force-pushing my branch to this repo so that I can (re)run a RHEL job?

@claraberendsen
Copy link
Contributor

Thanks! Would you (or anyone) mind force-pushing my branch to this repo so that I can (re)run a RHEL job?

Latest changes force pushed on christophebedard/install-liblttng-ctl-dev.

@christophebedard
Copy link
Member Author

Looking good now, see new CI (including RHEL) at ros2/ros2_tracing#81 (comment). This is ready for a final review.

@christophebedard
Copy link
Member Author

This should be ready to be merged.

@clalancette
Copy link
Contributor

@christophebedard Am I correct in thinking that this needs to be merged in concert with ros2/ros2_tracing#81 , so that Rolling nightlies continue to build?

@christophebedard
Copy link
Member Author

christophebedard commented Jan 9, 2024

Indeed! I can't merge this PR but I can merge the ros2_tracing one right after.

@christophebedard
Copy link
Member Author

@clalancette could you merge this PR? Then right after I can merge ros2/ros2_tracing#81.

@clalancette
Copy link
Contributor

@clalancette could you merge this PR? Then right after I can merge ros2/ros2_tracing#81.

I'm just going to go ahead and merge in both.

@clalancette clalancette merged commit 78f761b into ros2:master Jan 10, 2024
1 check passed
@christophebedard christophebedard deleted the christophebedard/install-liblttng-ctl-dev branch January 10, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants