Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable intra-process-comms for transient_local publisher #220

Closed
wants to merge 1 commit into from

Conversation

Yadunund
Copy link
Member

Fix #219

@clalancette
Copy link
Contributor

So I'm not certain of this, but I have the feeling that this should actually all work in jazzy/rolling. This is, I believe we added transient_local support to intra-process comms before Jazzy. Before we add in this workaround, can we make sure to try it there first?

@roncapat
Copy link

Fair point @clalancette ... In my issue I haven't specified the distro I was using (from source, mostly Iron with some additional backports).

Will give it a try (maybe this patch could instead be targeted directly on 'iron' branch)?

auto publisher_options = rclcpp::PublisherOptions();
// Explicitly disable intra_process_comms for this publisher alone to allow
// for this node to run in a component container with intra_process_comms enabled.
publisher_options.use_intra_process_comm = rclcpp::IntraProcessSetting::Disable;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is necessary. Does this mean subscribers in the same process don't receive messages from publishers if the publishers have transient_local durability? I would have expected them to still get the messages through the rmw API.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Iron and before an exception would be thrown by rclcpp. I wasn't aware that support for this was added in Jazzy/Rolling. So we can close this PR

@clalancette
Copy link
Contributor

I'm going to close this for now, as we don't need this on rolling. If you'd like to see it on iron or humble, please feel free to open a PR to that branch.

@clalancette clalancette closed this Jul 2, 2024
@clalancette clalancette deleted the yadu/fix-intra-process-qos branch July 2, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intra-process comm not supported due to transient_local durability
4 participants