Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of separating ROS messages into an another package (maybe cv_msgs?) like pcl_msgs #10

Open
wkentaro opened this issue May 31, 2016 · 4 comments

Comments

@wkentaro
Copy link
Member

There are many reusable ROS messages in this package.
Why not separating them into an another package like pcl_msgs?

@k-okada
Copy link
Contributor

k-okada commented Jun 1, 2016

I tried to discussion this topic at ros-perception/vision_opencv#56 (comment)

this package contains a lot of new message, show we create opencv_msgs that holds opencv basic data structure ? or ask other packages (geometry_msgs or others ) to add new messages?

Basic question is

  • current msg try to support opencv types as ros messages, and would like to know if this is the right direction
  • if this is ok, we need to check if current implementation covers all opencv data types

@wkentaro
Copy link
Member Author

wkentaro commented Jun 1, 2016

current msg try to support opencv types as ros messages, and would like to know if this is the right direction

IMO, the types in opencv are mostly well refined and creating message for that is reasonable thing, because it seems that OpenCV is more famous than ROS.
But I also think we can reuse messages in geometry_msgs for some messages in this package, for example

if this is ok, we need to check if current implementation covers all opencv data types

Maybe we can add new messages when we need. We can discuss about adding a new message at that time.

@hh129sss5
Copy link

Not approved no changes overview

@hh129sss5
Copy link

Not approved no changes overview

Denied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants