Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port parameter declared check compressed image transport subscription #82

Closed

Conversation

p0wdrdotcom
Copy link

This fixes a bug where more than one compressed image subscription would fail due to the following exception.

terminate called after throwing an instance of 'rclcpp::exceptions::ParameterAlreadyDeclaredException' what(): parameter 'mode' has already been declared
This has been fixed in future versions (galactic) but is not available for foxy.

@wep21
Copy link

wep21 commented Oct 23, 2021

This resolves #83.

@wep21
Copy link

wep21 commented Oct 23, 2021

@mjcarroll
ros2-gbp/image_transport_plugins-release#2
Does galactic release refer to foxy-devel?

@wep21
Copy link

wep21 commented Dec 7, 2021

@mjcarroll @jacobperron friendly ping

1 similar comment
@wep21
Copy link

wep21 commented Dec 23, 2021

@mjcarroll @jacobperron friendly ping

@jacobperron
Copy link
Contributor

For posterity, this is a partial backport of #73.

Perhaps we should include similar changes to the publisher code as well to avoid the same exception. What do you think @p0wdrdotcom @wep21 ?

@wep21
Copy link

wep21 commented Jan 8, 2022

@jacobperron I created a PR including modification for the publisher and the subscriber derived from #73 in #86.
Could you review the change?

@wep21
Copy link

wep21 commented Jan 21, 2022

@jacobperron friendly ping

@ijnek
Copy link
Member

ijnek commented Apr 8, 2022

I'd like this issue fixed but there seems to be not much progress made here.

Who's the maintainer of this package? @dgossow is listed in package.xml, but is that up-to-date?

@jacobperron
Copy link
Contributor

I think @mjcarroll might be the maintainer (though I can also help out).

I think this was fixed in #86. It hasn't been released yet though. I can make a release now. Let me know the issue persists.

@jacobperron jacobperron closed this Apr 9, 2022
@jacobperron
Copy link
Contributor

Releases for Foxy and Galactic:

@mjcarroll FYI, I bumped the minor for Rolling to make room for patch releases for Foxy/Galactic.

@ijnek
Copy link
Member

ijnek commented Apr 9, 2022

Great, thanks @jacobperron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants