-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port parameter declared check compressed image transport subscription #82
Conversation
This resolves #83. |
@mjcarroll |
@mjcarroll @jacobperron friendly ping |
1 similar comment
@mjcarroll @jacobperron friendly ping |
For posterity, this is a partial backport of #73. Perhaps we should include similar changes to the publisher code as well to avoid the same exception. What do you think @p0wdrdotcom @wep21 ? |
@jacobperron I created a PR including modification for the publisher and the subscriber derived from #73 in #86. |
@jacobperron friendly ping |
I'd like this issue fixed but there seems to be not much progress made here. Who's the maintainer of this package? @dgossow is listed in package.xml, but is that up-to-date? |
I think @mjcarroll might be the maintainer (though I can also help out). I think this was fixed in #86. It hasn't been released yet though. I can make a release now. Let me know the issue persists. |
Releases for Foxy and Galactic:
@mjcarroll FYI, I bumped the minor for Rolling to make room for patch releases for Foxy/Galactic. |
Great, thanks @jacobperron |
This fixes a bug where more than one compressed image subscription would fail due to the following exception.
terminate called after throwing an instance of 'rclcpp::exceptions::ParameterAlreadyDeclaredException' what(): parameter 'mode' has already been declared
This has been fixed in future versions (galactic) but is not available for foxy.