use cv::DestroyAllWindows (#863)

This ports #816 to ROS 2 and prevents weird exit conditions if you already closed the window
ros-perception · Jan 19, 2024 · 5645baa · 5645baa
1 parent ca363d9
commit 5645baa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/image_view/src/disparity_view_node.cpp b/image_view/src/disparity_view_node.cpp
@@ -92,7 +92,7 @@ DisparityViewNode::DisparityViewNode(const rclcpp::NodeOptions & options)
 
 DisparityViewNode::~DisparityViewNode()
 {
-  cv::destroyWindow(window_name_);
+  cv::destroyAllWindows();
 }
 
 void DisparityViewNode::imageCb(const stereo_msgs::msg::DisparityImage::SharedPtr msg)

diff --git a/image_view/src/image_view_node.cpp b/image_view/src/image_view_node.cpp
@@ -288,7 +288,7 @@ void ImageViewNode::windowThread()
     }
   }
 
-  cv::destroyWindow(window_name_);
+  cv::destroyAllWindows();
 
   if (rclcpp::ok()) {
     rclcpp::shutdown();