Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make apt work with unsigned repositories #1070

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 18, 2024

If an empty key is given for a repository in the buildfarm configuration, use the repository without verifying the GPG signature of the metadata.

This is already how the RPM jobs work.

Follow-up to #947

If an empty key is given for a repository in the buildfarm
configuration, use the repository without verifying the GPG signature of
the metadata.

This is already how the RPM jobs work.
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only glanced at the code and reviewed the change concept.
I haven't actually tested this locally but I assume this PR was exercised while testing colcon-ros-buildfarm.

@cottsay
Copy link
Member Author

cottsay commented Nov 1, 2024

I assume this PR was exercised while testing colcon-ros-buildfarm.

Indeed, the non-signed path was exercised by colcon-ros-buildfarm. The CI jobs on this PR lack the [trusted=yes] part and demonstrate that there is no change in behavior for signed repositories.

@cottsay cottsay merged commit 383dc7c into master Nov 1, 2024
24 checks passed
@cottsay cottsay deleted the cottsay/disable-apt-gpg branch November 1, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants