Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn of script location in rosdoc2 #1058

Merged

Conversation

rkent
Copy link
Contributor

@rkent rkent commented Jun 26, 2024

Fixes #1051 which is concerned with WARNING: The script normalizer is installed in '/home/buildfarm/.local/bin'

@nuclearsandwich asked "it's also worth determining whether this warning is valid"

No, the warning is not valid. In the build step following the rosdoc2 install, the PATH is extended to include the warned-about directory.

This warning used to be repressed. That repression was removed in PR #1031, possibly inadvertently. This PR simply restores the original option.

@nuclearsandwich
Copy link
Contributor

That repression was removed in PR #1031, possibly inadvertently.

Well I didn't document it, which, boo me, but I am sure I had some reason since I don't like to change things until I understand them. I normally look to my commit messages for concrete rationale but that PR and #1030 went through a few rounds of rebases and it looks like I lost the reason, but from the vague memory I have left and 6c398ef, I thought that the warning was caused by the way the source directory was being mounted and thus any new warning was for a different problem.

@nuclearsandwich nuclearsandwich merged commit f068f74 into ros-infrastructure:master Jul 12, 2024
24 checks passed
@rkent rkent deleted the stop_rosdoc2_warnings branch July 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings in rosdoc2 jobs
2 participants