chore: improve signal handling code #344
Merged
+35
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Relax ClearSignal function - now it can be called on unregistered signals (before it check-failed) 2. Now it is possible to install the ignore handler, which is what we really want to use when we clear the signal handlers via AcceptServer. Indeed, if accept server is shut down, the process will usually exit right after. There will be some clean up code but that's it. So we do not want to interrupt due sigterm/sigint signals because we are already in the process of shutting down anyway. Before this change - if we got the signal during the critical section after the accept server handlers were cleared, and default handlers were installed, the process would exit with -15 for SIGTERM and -2 for SIGINT just because it would catch these signals during the shutdown. Signed-off-by: Roman Gershman <[email protected]>
romange
changed the title
chakaz
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is what we really want to use when we clear the signal handlers via AcceptServer.
Indeed, if accept server is shut down, the process will usually exit right after.
There will be some clean up code but that's it. So we do not want to interrupt due sigterm/sigint signals because
we are already in the process of shutting down anyway. Before this change - if we got the signal during the
critical section after the accept server handlers were cleared, and default handlers were installed,
the process would exit with -15 for SIGTERM and -2 for SIGINT just because it would catch these signals
during the shutdown.