Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command(:create, result: :many) for combines #686

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix command(:create, result: :many) for combines #686

wants to merge 1 commit into from

Commits on Sep 28, 2023

  1. Fix command(:create, result: :many) for combines 

    - In ruby 3.x the `result: :many` will get forwarded incorrectly if there is a `combine`. That is, something like `relation.command(:create, result: :many)` will work but `relation.combine(:child_relation).command(:create, result: :many)` will raise `ArgumentError: wrong number of arguments (given 2, expected 1)`. This fixes is it (I have tested by doing the following on my codebase `ROM::Relation::Combined.__send__(:ruby2_keywords, :command)`).
    @dgollahon-plaid
    dgollahon-plaid committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    163d551 View commit details
    Browse the repository at this point in the history