Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for flutter using dart generator #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

humblerookie
Copy link
Contributor

Description

We use flutter a lot in my company and have been using arkana for our ios projects, so thought of adding support for flutter.

This builds on an infra similar to @husseinala's #53.

Arkana Arguments

The --lang operator now supports dart.

Arkana YAML config

The existing result_path allows you to specify a subfolder path/location in the dart project.

Generated Assets

{namespace}.dart

Screenshot 2024-06-14 at 1 12 39 PM

{namespace}_environment.dart

Screenshot 2024-06-14 at 1 12 54 PM

{namespace}_tests.dart

Screenshot 2024-06-14 at 1 15 10 PM

Footnotes

The import path in tests file is currently relative although absolute/package imports are preferred. However, package imports would require us to

  • read the dart project's pubspec for namespace
  • or add a new parameter both of which I find to be overkill.

I'd appreciate any recommendations and love to hear your thoughts on this.

@humblerookie
Copy link
Contributor Author

@rogerluan Any thoughts on this? Would appreciate any feedback

@rogerluan
Copy link
Owner

rogerluan commented Jul 3, 2024

Hi @humblerookie ! Sorry for the radio silence, I haven't had time to review this yet as my weeks have been pretty hectic 🤕 I promise to come back to this as soon as I can! Meanwhile, you can always point your Gemfile to this PR if you need to use this code, like this:

gem 'arkana', git: 'https://github.com/humblerookie/arkana.git', branch: 'main'

And run bundle install to apply the changes.

I hope I'm not blocking your awesome work!

Again, I'll try to come back to this and give this a proper review some time soon 🙏 Thanks a lot for your contribution! ❤️

@humblerookie
Copy link
Contributor Author

@rogerluan No worries at all, and thanks for the suggestions.

@humblerookie
Copy link
Contributor Author

@rogerluan Do you think you might get sometime this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants