Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying
get_opts
returns aGetResult
. So ideally it would be nice to return a Python object that wraps thisGetResult
so that in the future we could potentially stream a result into a Python AsyncIterator. However I don't think that would ever be possible because itsbytes
andinto_stream
consumeself
. And you can't have a Python method that consumesself
.So I think the best approach is to currently return
bytes
and potentially in the future have a separateget_opts_stream
method that returns an async iterator.I had tried with
This is implemented on top of #6, and is expected to be reviewed after that.