Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to display remission from a DepthMap using ImageView #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chhtz
Copy link
Member

@chhtz chhtz commented Jul 13, 2017

A DepthMap often contains remission information (usually reflectance of IR light) which can be of interest.

@chhtz
Copy link
Member Author

chhtz commented Jul 18, 2017

Any opinions on this?

Would it be preferable to implement a new independent viewer for that? That would make it easier to customize the view, e.g. also encode distances using the hue -- or scale the image according to the actual resolutions.

@doudou
Copy link
Member

doudou commented Jul 18, 2017

I was kind-of hoping somebody else would kick in ... but anyways.

I think it would be preferable to create a separate viewer, yes. Which could defniitely use the ImageViewer behind the scenes to do the actual display. Overloading existing viewers for unrelated topics creates monsters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants