Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check for presence of the java plugin in module-info plugin #334

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

robstoll
Copy link
Owner

all we need is a compileJava Task

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.92%. Comparing base (5676b3c) to head (a0cd1ab).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dle/plugins/kotlin/module/info/ModuleInfoPlugin.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #334   +/-   ##
=========================================
  Coverage     48.92%   48.92%           
  Complexity       56       56           
=========================================
  Files            13       13           
  Lines           605      605           
  Branches         81       81           
=========================================
  Hits            296      296           
  Misses          273      273           
  Partials         36       36           
Flag Coverage Δ
current 48.92% <0.00%> (ø)
current_windows 48.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit b2d961a into main Oct 31, 2024
9 of 10 checks passed
@robstoll robstoll deleted the bugfix/module-info-remove-java-plugin-check branch October 31, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant