Bug: Issue with formData not updating when dependencies change #4388
+2,101
−1,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Wow, this change is really hard to parse given how much has changed.
There was a problem hiding this comment.
Yeah, I know I tried to make it little easier with comments. If it's is really hard to grasp and makes things complicated, maybe I can try to simplify it a bit more but I'm not sure if I have time this week.
nickgros
reviewed
Nov 22, 2024
| * @param formData The current formData | ||
| * @returns valid formData | ||
| */ | ||
| export function getValidFormData<T = any, S extends StrictRJSFSchema = RJSFSchema, F extends FormContextType = any>( |
There was a problem hiding this comment.
This doesn't really check validity w.r.t. to the schema so I think this name might be confusing. Maybe getFormDataMatchingSchema?
There was a problem hiding this comment.
Hi @nickgros, I think it's a much better name but I've changed it to ensureFormDataMatchingSchema because I think it's slightly better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4325
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.