Use default values when switching anyOf option

[quentin-sommer]

Reasons for making this change

The UI wasn't properly handling the option change resulting in undefined data (See my video in #4367).

In summary this change makes this schema work as expected:

{
  "additionalProperties": false,
  "properties": {
    "any_of_array_or_null": {
      "anyOf": [
        {
          "items": {
            "type": "integer"
          },
          "type": "array",
          "title": "Array value selected",
          "default": []
        },
        {
          "type": "null",
          "title": "Null value selected"
        }
      ]
    }
  },
  "required": [
    "any_of_array_or_null"
  ],
  "type": "object"
}

But when removing the default value for the array field the UI doesn't render a + button. I have no idea how/where to fix this. In the playground an array without data is rendered with a +. I expect there is a function somewhere that can provide a default value for this

Works after @nickgros's suggestion

fixes #4367

Checklist

• I'm updating documentation
  • I've checked the rendering of the Markdown text I've added
• I'm adding or updating code
  • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
  • I've updated docs if needed
  • I've updated the changelog with a description of the PR
• I'm adding a new feature
  • I've updated the playground with an example use of the feature

[nickgros]

@quentin-sommer A couple of thoughts:

Does your change fix the original issue in #4367 ? When I tried it locally it did not seem to fix it, but I want to confirm with you.

Instead of changing sanitizeDataForNewSchema, it seems like we could let getDefaultFormState handle this case. Since sanitizeDataForNewSchema is only called in MultiSchemaField, what do you think of changing MultiSchemaField L126 from

    if (newFormData && newOption) {

to

    if (newOption) {

Your test seems to pass with this change, but I want to make sure I'm not missing an edge case I am unaware of.

[quentin-sommer]

I applied your suggestion and it fixes the original issue in #4367 as well as the schema in this PR description, thanks!

I also added a changelog entry. Let me know if this looks good to go

[heath-freenome]

Can you add a similar test for the oneOf.test.jsx file?

[quentin-sommer]

Sure thing, PR updated 👍

Just noticed one more change