-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mantine UI package #3622
base: main
Are you sure you want to change the base?
Add mantine UI package #3622
Conversation
@pkalisiewicz Can you fix your build, then I will take a look at the PR |
Sure, I'm just having an issue with I have temporarily commented out code that is adding mantine in playground until, I'll find a solution:) |
@pkalisiewicz Ah, yeah that is an issue with adding new themes. I'm wrapping up a new feature and will take a look at this PR by next Monday. Sorry for the delay |
@pkalisiewicz it looks like there is a typescript issue with your build?
|
@pkalisiewicz If you can fix the build issues and deal with the conflicts, I can release your changes as part of 5.8.0 and then in 5.8.1 we can enable mantine-ui in the playground |
hey @heath-freenome I have updated my PR, locally everything builds fine. |
@pkalisiewicz It looks like the build is still having the Typescript issue. |
@heath-freenome Sorry about that, I just realized I didn't add mantine it to the devDependencies, and it was getting the node modules from the root locally, but on the instance, it couldn't. That's solved! |
@pkalisiewicz It still isn't working with the same typescript issue. |
@pkalisiewicz Have you figured out why the builds keep failing with a typescript issue? |
Stumbled across this PR as I'd really like to use RJSF with Mantine in some of my company's projects! I have a hunch that the error in the CI build is being caused by a versioning issue with Mantine. The
The input component docs for Mantine v5 and v6 both include I'd suspect that bumping the minimum required version of Mantine up to v5 for both peer and dev dependencies would resolve the TypeScript build issue. I'll test this out locally when I get a chance, but thought I'd note this here in case it's helpful! |
I reproduced the TypeScript build error locally. Updating the minimum required version of Mantine to v5 resolves the issue and the build succeeds. |
@pkalisiewicz Can you update the mantine version to v5 and try again? |
So sorry for the late response. I have updated it now |
@pkalisiewicz two things, first please revert any of the |
Super interested in this! |
Hope to see this getting sorted soon! |
@pkalisiewicz @dbsmck @nachiket-p We need someone to help get these changes over the line |
hey @pkalisiewicz, any chance you'd do this soon or someone should handle the remaining issues? |
@msjaber If you'd like to take over please do so! |
Any update on this? I'd love to see this go live and use it! |
I am developing Mantine theme based on Mantine v7. Though it can't be taken over this PR, due to incompatibility between |
@pkalisiewicz I hope you are ok, This PR is just waiting for you to finish it |
Which version of |
@heath-freenome None would work as long as it relies on iframes. Mantine v7 has removed the Emotion dependency as well as the function to change the container into iframe like this. Without the function, iframe's CSS encapsulation would break. I could not fix it with v7, so I decided to fork it and make my own playground that don't use iframes. |
Reasons for making this change
I wanted to add another provider, which is Mantine to allow to use their components withing rjsf library.
If this is related to existing tickets, include links to them as well. Use the syntax
fixes #[issue number]
(ex:fixes #123
).If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit
Checklist
npm run test:update
to update snapshots, if needed.