Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in PE format #4727

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix memory leaks in PE format #4727

merged 1 commit into from
Nov 22, 2024

Conversation

Roeegg2
Copy link
Contributor

@Roeegg2 Roeegg2 commented Nov 22, 2024

  • Fix freeing of relocation array when no relocations are present

  • Reimplement canary checking for PE for speed + getting rid of memory leak when calling imports()

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

All tests green
...

* Fix freeing of relocation array when no relocations are present

* Reimplement canary checking for PE for speed + getting rid of memory leak when calling imports()
@wargio wargio merged commit db60b71 into rizinorg:dev Nov 22, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants