-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting pf
commands to rzshell
#3467
Conversation
45733eb
to
efb04eb
Compare
47c1894
to
13d07e9
Compare
13d07e9
to
81f2a29
Compare
15ab3d1
to
0d59cbf
Compare
0d59cbf
to
43e2fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
43e2fc0
to
51f8a5b
Compare
f77e7de
to
bfe5256
Compare
86caa1d
to
b232c1f
Compare
b232c1f
to
abe7ebf
Compare
- text: "pf '3xi foo bar'" | ||
comment: "3-array of structures, each with named fields: 'foo' as hex, 'bar' as int" | ||
- text: "pf 'B (BitFldType)arg_name'" | ||
comment: "Resolve bitfield enum type for the arg_name" | ||
- text: "pf 'E (EnumType)arg_name'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we have each named argument as a separate argument of the pf
command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in theory. But that would require rewriting almost all of the librz/type/format.c
, which is an immense task in itself and is a story for another time. Moreover, it would make sense to rethink the format syntax/semantics before that task as well: #783
abe7ebf
to
ba58cb1
Compare
ba58cb1
to
fb0c014
Compare
fb0c014
to
54bd4c9
Compare
faf5128
to
377b8c1
Compare
70684fb
to
9e41073
Compare
pf
commands to rzshellpf
commands to rzshell
19a288e
to
fc4f71e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup
fc4f71e
to
094b978
Compare
Your checklist for this pull request
Detailed description
pf.
now requires space after dotpf
command now recognizes named format - it should start from dot, e.g.pfs .bla
wherebla
is the format namepfn <format name> <format>
pfn
(before -pf.
)pfn <format name>
, previouslypf.bla
pfw
command instead of justpf
orpf.
pfw
now supports both variants:pfw bla.foo 42
andpfw bla.foo=42
Test plan
CI is green
Closing issues
Partially addresses #1590
Partially addresses #3842