Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert p= commands to rzshell #3324

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Convert p= commands to rzshell #3324

merged 2 commits into from
Jan 31, 2023

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jan 27, 2023 •
edited
Loading

DO NOT SQUASH

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Convert all p= (and corresponding p== subcommands) to rzshell.
  • Removed p=b as an alias to p= (and p==b as an alias to p==)
  • Removed QUIET and JSON modes for p= commands, there is no viable reason to need this, or we should provide a proper API instead for that.

Test plan

CI is green

Closing issues

Partially addresses #1590

@XVilka XVilka added this to the 0.5.0 milestone Jan 27, 2023
@XVilka XVilka mentioned this pull request Jan 27, 2023
Open
32 tasks
@XVilka XVilka force-pushed the asan-print-bars branch 2 times, most recently from fd6c0b0 to 678c05a Compare January 29, 2023 14:26
@XVilka XVilka marked this pull request as ready for review January 29, 2023 14:27
wargio
wargio requested changes Jan 30, 2023
View reviewed changes
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
@XVilka XVilka requested a review from wargio January 30, 2023 13:15
@wargio
Copy link
Member

wargio commented Jan 30, 2023

run clang-format

@XVilka
Copy link
Member Author

XVilka commented Jan 30, 2023

run clang-format

I did, it passes locally. Failure of the worker is due to network during LLVM installation stage.

wargio
wargio approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@XVilka XVilka merged commit 5082c1f into dev Jan 31, 2023
@XVilka XVilka deleted the asan-print-bars branch January 31, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
rz-test RzCons RzCore
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio