Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pi commands to rzshell #3187

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Convert pi commands to rzshell #3187

merged 1 commit into from
Nov 16, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 14, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Convert all pi commands to rzshell
  • Remove some unreachable code

Test plan

  • CI is green
  • Try different pi commands

Closing issues

Partially addresses #1590

@XVilka XVilka mentioned this pull request Nov 14, 2022
Open
32 tasks
@XVilka XVilka added this to the 0.5.0 milestone Nov 14, 2022
ret2libc
ret2libc approved these changes Nov 15, 2022
View reviewed changes
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
wargio
wargio requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the eprintf at line 3350 inside cmd_print.c with RZ_LOG_ERROR

librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved
@XVilka XVilka requested a review from wargio November 16, 2022 00:34
wargio
wargio reviewed Nov 16, 2022
View reviewed changes
librz/core/cmd/cmd_print.c
static void func_walk_blocks(RzCore *core, RzAnalysisFunction *f, char input, char type_print, bool fromHere) {
RzListIter *iter;
RzAnalysisBlock *b = NULL;
static void func_walk_blocks(RzCore *core, RzAnalysisFunction *f, bool fromHere, RzCmdStateOutput *state) {
const char *orig_bb_middle = rz_config_get(core->config, "asm.bb.middle");
rz_config_set_i(core->config, "asm.bb.middle", false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is set but never restored :/

@wargio wargio merged commit 8226cc5 into dev Nov 16, 2022
@wargio wargio deleted the asan-fuzz-print-i-rzshell branch November 16, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@wargio wargio wargio approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@XVilka @wargio @ret2libc